mirror of
https://github.com/profullstack/logicsrc.git
synced 2026-08-13 14:37:26 +00:00
Anthony Ettinger
bb09c145cd
#109 addressed vaults as <project>/<env> and shipped broken: every push failed with Vault name must be lowercase letters, numbers, and dashes. The vault-create endpoint slugifies through /^[a-z0-9][a-z0-9-]{0,62}$/ (apps/pwa/src/routes/credshare.mjs), so a "/" join is refused outright. Nothing in the CLI ever saw it, because the tests exercised vaultName and splitVaultName in isolation and never made a request — the one assumption that mattered, that the server takes an arbitrary vault name, was the one left unverified. Switches the separator to "--", which is inside the allowed character set and still splits unambiguously since neither half may contain one. A single dash would not: "a-b" + "c" and "a" + "b-c" would collide. Also validates the joined name against the server's own regex before the request, so a bad name fails locally with a useful message rather than a 422 after the .env has been read. The tests now assert the produced name matches that regex, so the separator cannot drift back out of the allowed set without failing. Verified end to end against app.logicsrc.com: push, then pull into a scratch file and diff — keys and values both round-trip losslessly. Then 49 repos pushed under the profullstack team; server reports 49 vaults, 169 secrets, 0 failures. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| openprd | ||
| agent-screening.md | ||
| agentad-marketplace.md | ||
| agentad.md | ||
| agentgit.md | ||
| agentstack.md | ||
| ans-sdk.md | ||
| arcade.md | ||
| cli.md | ||
| communication-accounts.md | ||
| config.md | ||
| credential-sharing.md | ||
| data-model.md | ||
| openapi.yaml | ||
| openontology-governance.md | ||
| openontology-interoperability.md | ||
| openontology.md | ||
| openprd.md | ||
| openspec-comparison.md | ||
| permissions.md | ||
| plugins.md | ||
| positioning.md | ||
| roadmap.md | ||
| tui.md | ||