From e89c10cc800c4b49a3fb6f2dafc3c94778a8d054 Mon Sep 17 00:00:00 2001 From: Autowebassat-blip Date: Sun, 14 Jun 2026 07:56:12 +0200 Subject: [PATCH] Reject malformed CoinPay webhook signatures (#41) * Reject malformed CoinPay webhook signatures * Fix webhook signature type guard --------- Co-authored-by: Codex Microtask Operator --- apps/logicsrc-web/contract/logicsrc-web.contract.test.ts | 1 + apps/logicsrc-web/src/lib/coinpay.ts | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/apps/logicsrc-web/contract/logicsrc-web.contract.test.ts b/apps/logicsrc-web/contract/logicsrc-web.contract.test.ts index ddaec4f..7ab226d 100644 --- a/apps/logicsrc-web/contract/logicsrc-web.contract.test.ts +++ b/apps/logicsrc-web/contract/logicsrc-web.contract.test.ts @@ -433,6 +433,7 @@ describe("POST /api/webhooks/coinpay", () => { expect(verifyCoinPayWebhook(payload, `t=${timestamp},v1=${signature}`, secret)).toBe(true); expect(verifyCoinPayWebhook(payload, `t=${timestamp}, v1=${signature}`, secret)).toBe(true); + expect(verifyCoinPayWebhook(payload, `t=${timestamp},v1=${signature}0`, secret)).toBe(false); const response = await coinpayWebhook( new NextRequest("http://localhost/api/webhooks/coinpay", { diff --git a/apps/logicsrc-web/src/lib/coinpay.ts b/apps/logicsrc-web/src/lib/coinpay.ts index b0efeba..f71c7cf 100644 --- a/apps/logicsrc-web/src/lib/coinpay.ts +++ b/apps/logicsrc-web/src/lib/coinpay.ts @@ -117,7 +117,7 @@ export function verifyCoinPayWebhook( const parts = signatureHeader.split(",").map((part) => part.trim()); const timestamp = parts.find((part) => part.startsWith("t="))?.slice(2); const signature = parts.find((part) => part.startsWith("v1="))?.slice(3); - if (!timestamp || !signature) { + if (!timestamp || !signature || !/^[0-9a-fA-F]{64}$/.test(signature)) { return false; }