Reject unknown task assignees

This commit is contained in:
phucnguyen1707 2026-06-16 11:31:31 +07:00
parent 82e1389b8d
commit 662b805ffb
2 changed files with 33 additions and 17 deletions

View file

@ -109,16 +109,29 @@ describe("AgentStack coordinator", () => {
expect(listener).toHaveBeenCalledWith(expect.objectContaining({ type: "delegation.granted" }));
});
it("rejects unknown agents and invalid DIDs", () => {
const stack = new AgentStack();
expect(() => stack.createTask({ ownerDid: "nope", sourceApp: "x", title: "t" })).toThrow();
const task = stack.createTask({ ownerDid: owner, sourceApp: "x", title: "t" });
expect(() => stack.assignTask(task.id, agentDid("ghost"))).toThrow(/Unknown agent/);
});
it("filters tasks in snapshots", () => {
const stack = new AgentStack();
stack.createTask({ ownerDid: owner, sourceApp: "x", title: "a" });
it("rejects unknown agents and invalid DIDs", () => {
const stack = new AgentStack();
expect(() => stack.createTask({ ownerDid: "nope", sourceApp: "x", title: "t" })).toThrow();
const task = stack.createTask({ ownerDid: owner, sourceApp: "x", title: "t" });
expect(() => stack.assignTask(task.id, agentDid("ghost"))).toThrow(/Unknown agent/);
});
it("rejects tasks preassigned to unknown agents", () => {
const stack = new AgentStack();
expect(() =>
stack.createTask({
ownerDid: owner,
sourceApp: "ugig.net",
title: "Ghost assignment",
assigneeDid: agentDid("ghost")
})
).toThrow(/Unknown agent/);
expect(stack.listTasks({ assigneeDid: agentDid("ghost") })).toHaveLength(0);
});
it("filters tasks in snapshots", () => {
const stack = new AgentStack();
stack.createTask({ ownerDid: owner, sourceApp: "x", title: "a" });
stack.createTask({ ownerDid: userDid("999"), sourceApp: "x", title: "b" });
expect(stack.listTasks({ ownerDid: owner })).toHaveLength(1);
expect(stack.snapshot().tasks).toHaveLength(2);

View file

@ -83,13 +83,16 @@ export class AgentStack {
return this.agents.get(did);
}
createTask(input: CreateTaskInput): DidTask {
if (!parseDid(input.ownerDid)) {
throw new Error(`Invalid owner DID: ${input.ownerDid}`);
}
const ts = this.now();
const task: DidTask = {
id: this.nextId("task"),
createTask(input: CreateTaskInput): DidTask {
if (!parseDid(input.ownerDid)) {
throw new Error(`Invalid owner DID: ${input.ownerDid}`);
}
if (input.assigneeDid && !this.agents.has(input.assigneeDid)) {
throw new Error(`Unknown agent: ${input.assigneeDid}`);
}
const ts = this.now();
const task: DidTask = {
id: this.nextId("task"),
ownerDid: input.ownerDid,
assigneeDid: input.assigneeDid,
sourceApp: input.sourceApp,