bbs.profullstack/logicsrc
1
0
Fork 0
mirror of https://github.com/profullstack/logicsrc.git synced 2026-08-14 14:57:28 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

fix(validators): isSchemaKind no longer accepts inherited prototype keys (#14)

Browse source 
'value in schemas' walks the prototype chain, so inherited keys like
"toString" passed assertSchemaKind and then crashed ajv.compile with a
misleading 'schema must be object or boolean' error (e.g. via the CLI).
Use Object.hasOwn for an own-property check.

Adds unit tests rejecting prototype keys and asserting every real
schema kind still passes.

Fixes #13
This commit is contained in:
6D0N9 2026-06-12 06:06:18 +02:00 • committed by GitHub
parent 73e2464b30
commit 3d4345b665
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 19 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
packages/validators/src/schemas.ts
View file

@ -41,5 +41,5 @@ export const schemas = {
export type SchemaKind = keyof typeof schemas;
export function isSchemaKind(value: string): value is SchemaKind {
return value in schemas;
return Object.hasOwn(schemas, value);
}