bbs.profullstack/agentbbs
1
0
Fork 0
mirror of https://github.com/profullstack/agentbbs.git synced 2026-08-13 22:37:28 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

payments: accept CoinPay crypto_amount as number or string

Browse source 
The live CoinPay API returns crypto_amount as a bare JSON number (e.g.
0.0031), but the struct decoded it as a string, so /payments/create failed
with "cannot unmarshal number into ... crypto_amount of type string" and
join@ showed "Payment is temporarily unavailable". The unit test had hidden
the bug by sending the value quoted.

Add a flexStr type that unmarshals from either a JSON number or string and
use it for crypto_amount; update the test to send a number and add a direct
flexStr decode test for both forms.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Anthony Ettinger 2026-06-14 11:45:21 +00:00
parent 641fa01d9a
commit d5135cd1fe
2 changed files with 48 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

38
internal/payments/payments.go
View file

@ -92,15 +92,39 @@ func Reference(plan, pubkeyFP string) string {
return "abbs-" + plan + "-" + hex.EncodeToString(mac.Sum(nil))[:12]
}
// flexStr decodes a JSON value that may arrive as either a string or a number
// into a string. CoinPay returns crypto_amount as a bare JSON number (e.g.
// 0.0031), but has sent it quoted in the past — accept both so a representation
// change on their side can't break the charge again.
type flexStr string
func (f *flexStr) UnmarshalJSON(b []byte) error {
b = bytes.TrimSpace(b)
if len(b) == 0 || string(b) == "null" {
*f = ""
return nil
}
if b[0] == '"' {
var s string
if err := json.Unmarshal(b, &s); err != nil {
return err
}
*f = flexStr(s)
return nil
}
*f = flexStr(b) // number (or other scalar) — keep its literal text
return nil
}
// coinpayPayment is the (subset of the) CoinPay payment object, returned
// wrapped as {"payment": {…}}.
type coinpayPayment struct {
ID string `json:"id"`
Status string `json:"status"`
Address string `json:"payment_address"`
CryptoAmount string `json:"crypto_amount"`
CryptoCurr string `json:"crypto_currency"`
QR string `json:"qr_code"`
ID string `json:"id"`
Status string `json:"status"`
Address string `json:"payment_address"`
CryptoAmount flexStr `json:"crypto_amount"`
CryptoCurr string `json:"crypto_currency"`
QR string `json:"qr_code"`
}
type paymentEnvelope struct {
@ -174,7 +198,7 @@ func CreatePremiumCharge(ref string) (Charge, bool, error) {
}
return Charge{
Address: p.Address,
CryptoAmount: p.CryptoAmount,
CryptoAmount: string(p.CryptoAmount),
Currency: p.CryptoCurr,
FiatAmount: PremiumAmount(),
FiatCurrency: PremiumCurrency(),