bbs.profullstack/agentbbs
1
0
Fork 0
mirror of https://github.com/profullstack/agentbbs.git synced 2026-08-13 22:37:28 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix(nntp): support open-ended OVER/XOVER ranges ("n-")

Browse source 
parseRange treated a range of the form "low-" (low article to the
highest available) as malformed and returned an empty (0,0) range, so
OVER/XOVER "n-" returned no articles instead of every article >= n.
RFC 3977 defines a range as a single number, "number-", or
"number-number"; the open-ended form is common in real NNTP clients.

Handle "low-" as (low, MaxInt64), reject specs with more than one dash
(e.g. "1-2-3") as malformed, and keep existing malformed handling so a
bad range still yields an empty range rather than "all articles".
Adds tests for closed, open-ended, empty, and malformed specs.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
johnanleitner1-Coder 2026-06-29 16:28:57 -07:00
parent 105ff0ed8a
commit c947fd9bf5
2 changed files with 48 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

40
internal/news/nntpd/range_test.go
View file

@ -1,6 +1,9 @@
package nntpd
import "testing"
import (
"math"
"testing"
)
func TestParseRangeSingleArticle(t *testing.T) {
low, high := parseRange("5")
@ -8,3 +11,38 @@ func TestParseRangeSingleArticle(t *testing.T) {
t.Fatalf(`parseRange("5") = %d, %d; want 5, 5`, low, high)
}
}
func TestParseRangeClosed(t *testing.T) {
low, high := parseRange("5-10")
if low != 5 || high != 10 {
t.Fatalf(`parseRange("5-10") = %d, %d; want 5, 10`, low, high)
}
}
// "low-" is a valid open-ended range meaning "from low to the highest
// article" (RFC 3977). It must not be treated as a malformed empty range,
// otherwise OVER/XOVER "n-" returns nothing instead of all articles >= n.
func TestParseRangeOpenEnded(t *testing.T) {
low, high := parseRange("5-")
if low != 5 || high != math.MaxInt64 {
t.Fatalf(`parseRange("5-") = %d, %d; want 5, %d`, low, high, int64(math.MaxInt64))
}
}
// Empty spec means "all articles".
func TestParseRangeEmptyIsAll(t *testing.T) {
low, high := parseRange("")
if low != 0 || high != math.MaxInt64 {
t.Fatalf(`parseRange("") = %d, %d; want 0, %d`, low, high, int64(math.MaxInt64))
}
}
// Malformed specs must yield an empty range (0,0), never "all articles".
func TestParseRangeMalformed(t *testing.T) {
for _, spec := range []string{"abc", "5-abc", "abc-5", "1-2-3", "-", "-5"} {
low, high := parseRange(spec)
if low != 0 || high != 0 {
t.Fatalf(`parseRange(%q) = %d, %d; want 0, 0`, spec, low, high)
}
}
}