mirror of
https://github.com/profullstack/agentbbs.git
synced 2026-08-13 22:37:28 +00:00
files: make ~member browsable before first session
A valid member's ~name 404'd until they'd opened their first SFTP/web session, because joining onto a not-yet-created site dir tripped the safeJoin escape guard (it walks up to sites/, outside the per-user root). AnonRoot now materializes the idempotent site dir for a known member, so ~name renders an empty listing the moment the account exists. Missing sub-paths and unknown members still 404. Adds a regression test. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
parent
192b117fc1
commit
87fb2b4a1f
3 changed files with 48 additions and 1 deletions
|
|
@ -195,6 +195,38 @@ func TestWebAnonPublicSite(t *testing.T) {
|
|||
}
|
||||
}
|
||||
|
||||
func TestWebAnonMemberSiteEmptyNot404(t *testing.T) {
|
||||
// A registered member who has not published anything yet (no site dir on
|
||||
// disk) is reachable at ~name as an empty listing, not a 404. A missing file
|
||||
// under them, and an unknown member, both still 404.
|
||||
svc, st, _ := newTestService(t)
|
||||
if _, err := st.EnsureUser("bob", "member", "SHA256:bobkey"); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
h := svc.WebHandler(WebConfig{Title: "files.test"})
|
||||
|
||||
rr := httptest.NewRecorder()
|
||||
h.ServeHTTP(rr, httptest.NewRequest(http.MethodGet, "/~bob/", nil))
|
||||
if rr.Code != http.StatusOK {
|
||||
t.Fatalf("~bob (member, empty site): want 200, got %d", rr.Code)
|
||||
}
|
||||
if !strings.Contains(rr.Body.String(), "(empty)") {
|
||||
t.Fatalf("~bob should render an empty listing: %.200s", rr.Body.String())
|
||||
}
|
||||
|
||||
rr = httptest.NewRecorder()
|
||||
h.ServeHTTP(rr, httptest.NewRequest(http.MethodGet, "/~bob/nope.txt", nil))
|
||||
if rr.Code != http.StatusNotFound {
|
||||
t.Fatalf("~bob/nope.txt: want 404, got %d", rr.Code)
|
||||
}
|
||||
|
||||
rr = httptest.NewRecorder()
|
||||
h.ServeHTTP(rr, httptest.NewRequest(http.MethodGet, "/~nobody/", nil))
|
||||
if rr.Code != http.StatusNotFound {
|
||||
t.Fatalf("~nobody (unknown): want 404, got %d", rr.Code)
|
||||
}
|
||||
}
|
||||
|
||||
func TestWebAnonCannotEscape(t *testing.T) {
|
||||
h, _ := webTestHandler(t)
|
||||
cookie := loginCookie(t, h)
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue