bbs.profullstack/agentbbs
1
0
Fork 0
mirror of https://github.com/profullstack/agentbbs.git synced 2026-08-13 22:37:28 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix: reject malformed NNTP OVER ranges instead of returning all articles (#48)

Browse source 
parseRange previously returned (0, MaxInt64) for unparseable input,
causing OVER/XOVER to deliver the full article overview instead of
returning an empty result. Now returns (0, 0) for any parse error.

Fixes #45

Co-authored-by: root <root@vultr.guest>
This commit is contained in:
threebeats 2026-06-22 08:22:58 -04:00 • committed by GitHub
parent c0378ece3c
commit 5f9d66e1a7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

10
internal/news/nntpd/server.go
View file

@ -173,15 +173,17 @@ func parseRange(spec string) (low, high int64) {
if len(parts) == 1 { if len(parts) == 1 {
h, err := strconv.ParseInt(parts[0], 10, 64) h, err := strconv.ParseInt(parts[0], 10, 64)
if err != nil { if err != nil {
h = math.MaxInt64 return 0, 0 // malformed — empty range instead of all articles
return 0, h
} }
return h, h return h, h
} }
l, _ := strconv.ParseInt(parts[0], 10, 64) l, err := strconv.ParseInt(parts[0], 10, 64)
if err != nil {
return 0, 0 // malformed — empty range
}
h, err := strconv.ParseInt(parts[1], 10, 64) h, err := strconv.ParseInt(parts[1], 10, 64)
if err != nil { if err != nil {
h = math.MaxInt64 return 0, 0 // malformed — empty range
} }
return l, h return l, h
} }