bbs.profullstack/agentbbs
1
0
Fork 0
mirror of https://github.com/profullstack/agentbbs.git synced 2026-08-14 14:57:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(files): allow symlinked storage roots

Browse source
This commit is contained in:
Qyra-One 2026-06-28 05:11:09 -04:00
parent 105ff0ed8a
commit 5474d4e503
2 changed files with 51 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

39
internal/files/files_test.go
View file

@ -103,6 +103,45 @@ func TestSymlinkEscapeBlocked(t *testing.T) {
}
}
func TestSafeJoinAllowsSymlinkedAreaRoot(t *testing.T) {
dir := t.TempDir()
realRoot := filepath.Join(dir, "real-root")
if err := os.Mkdir(realRoot, 0o755); err != nil {
t.Fatal(err)
}
aliasRoot := filepath.Join(dir, "alias-root")
if err := os.Symlink(realRoot, aliasRoot); err != nil {
t.Skipf("symlink unsupported: %v", err)
}
joined, err := safeJoin(aliasRoot, "notes.txt")
if err != nil {
t.Fatalf("safeJoin should allow paths under a symlinked/canonicalized root: %v", err)
}
if !within(filepath.Clean(aliasRoot), joined) {
t.Fatalf("safeJoin returned %q, want under lexical root %q", joined, aliasRoot)
}
}
func TestSafeJoinRejectsEscapeThroughSymlinkedAreaRoot(t *testing.T) {
dir := t.TempDir()
realRoot := filepath.Join(dir, "real-root")
if err := os.Mkdir(realRoot, 0o755); err != nil {
t.Fatal(err)
}
aliasRoot := filepath.Join(dir, "alias-root")
if err := os.Symlink(realRoot, aliasRoot); err != nil {
t.Skipf("symlink unsupported: %v", err)
}
if err := os.Symlink("/etc", filepath.Join(realRoot, "escape")); err != nil {
t.Skipf("symlink unsupported: %v", err)
}
if _, err := safeJoin(aliasRoot, "escape/passwd"); err == nil {
t.Fatal("safeJoin should reject paths that escape through a symlink below the area root")
}
}
func TestOwnPublicWritable(t *testing.T) {
svc, _, u := newTestService(t)