bbs.profullstack/agentbbs
1
0
Fork 0
mirror of https://github.com/profullstack/agentbbs.git synced 2026-08-13 14:27:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix(arcade): give ncurses games a TERM so they launch

Browse source 
The 80s arcade classics (Space Invaders/nInvaders, Pac-Man/pacman4console,
Tetris/tint, Moon Patrol/moon-buggy) are ncurses programs: initscr() fails
with "Error opening terminal" when TERM is unset. Game subprocesses were
built with exec.Command and no Env, so they inherited the agentbbs systemd
daemon's environment — which has no TERM — and every game exited before
drawing a frame. DOOM was unaffected because doom-ascii writes ANSI directly
and never touches terminfo.

Thread the client PTY's TERM through plugin.Context and hand each sandboxed
game a curated environment (TERM, PATH, HOME, LANG=C.UTF-8) instead of the
daemon's. Curating the env also stops leaking operator secrets (e.g.
COINPAY_API_KEY) into third-party game binaries.

Verified live on bbs.profullstack.com: Space Invaders and Pac-Man now render;
previously all four died instantly.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Anthony Ettinger 2026-06-18 12:01:26 +00:00
parent beba7dc388
commit 481e715d89
3 changed files with 29 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

21
plugins/arcade/arcade.go
View file

@ -207,12 +207,32 @@ func (m *menu) workDir(sub string) string {
return d
}
// gameEnv is the minimal environment handed to a sandboxed game. It does NOT
// inherit the daemon's environment (which carries operator secrets like
// COINPAY_API_KEY) — a third-party game binary has no business seeing those.
// TERM comes from the client PTY so ncurses games (Space Invaders, Pac-Man,
// Tetris, Moon Patrol) can open the terminal; without it initscr() fails with
// "Error opening terminal" and the game exits before drawing a frame.
func (m *menu) gameEnv(work string) []string {
term := m.ctx.Term
if term == "" {
term = "xterm-256color" // sane default if the client didn't request a PTY type
}
return []string{
"TERM=" + term,
"PATH=/usr/games:/usr/local/games:/usr/local/bin:/usr/bin:/bin",
"HOME=" + work,
"LANG=C.UTF-8", // unicode box-drawing for the ncurses games
}
}
// launchDoom suspends the TUI and bridges the session to a sandboxed
// doom-ascii on a real PTY. Savegames land in the per-user work dir.
func (m *menu) launchDoom(wad string) tea.Cmd {
bin := doomBin(m.ctx)
work := m.workDir(filepath.Join("doom", strings.TrimSuffix(filepath.Base(wad), filepath.Ext(wad))))
cmd := m.ctx.Sandbox.Command(work, bin, "-iwad", wad)
cmd.Env = m.gameEnv(work)
return tea.Exec(newPtyExec(cmd, m.width, m.height), func(err error) tea.Msg {
return gameDoneMsg{name: "DOOM", err: err}
})
@ -228,6 +248,7 @@ func (m *menu) launchExt(g extGame) tea.Cmd {
}
work := m.workDir(g.id)
cmd := m.ctx.Sandbox.Command(work, bin, g.args...)
cmd.Env = m.gameEnv(work)
return tea.Exec(newPtyExec(cmd, m.width, m.height), func(err error) tea.Msg {
return gameDoneMsg{name: g.label, err: err}
})